Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SOT] Fix stringify dtype object in guard string #64118

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented May 8, 2024

PR Category

Execute Infrastructure

PR Types

Bug fixes

Description

修复 dtype 作为 guard string 的情况下,直接使用 repr 导致生成的 guard string 出错的问题(问题发生在 GetItemTracker),dtype 直接使用 repr 是不可以的,应该手写字符串 reconstruct,如 paddle.core.DataType({dtype.value})

另外清理一下 sot 目录的 run_in_both_default_and_pir,因为 PR-CI-Py3-PIR 会承担 PIR 模式的检测

PCard-66972

Copy link

paddle-bot bot commented May 8, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit 775fff9 into PaddlePaddle:develop May 9, 2024
31 checks passed
@SigureMo SigureMo deleted the sot/fix-stringify-dtype-object-in-guard-string branch May 9, 2024 01:58
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 10, 2024
co63oc pushed a commit to co63oc/Paddle that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants