Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR] Adapt distributed API broadcast #64190

Merged

Conversation

ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented May 10, 2024

PR Category

Others

PR Types

Others

Description

适配分布式 API broadcast,为 inplace 操作

Copy link

paddle-bot bot commented May 10, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label May 10, 2024
@ooooo-create ooooo-create changed the title [PIR] Adapt distributed API broadcast [PIR] Adapt distributed API broadcast May 10, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label May 10, 2024
@@ -59,6 +61,11 @@ def _broadcast_in_static_mode(
helper = framework.LayerHelper(op_type, **locals())
ring_id = 0 if group is None else group.id

if in_pir_mode():
op_type = _to_inplace_op(op_type)
getattr(_C_ops, op_type)(tensor, src_rank_in_group, sync_op, ring_id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的参数顺序有点问题,请参考paddle/fluid/pir/dialect/operator/ir/ops.yaml中c_broadcast的args顺序~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改~

Copy link

paddle-ci-bot bot commented May 24, 2024

Sorry to inform you that 4b48e0c's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

Copy link
Contributor

@JZ-LIANG JZ-LIANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JZ-LIANG JZ-LIANG merged commit 35a4e3b into PaddlePaddle:develop May 30, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants