Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PIR saveload]Fix save_load bf16 bug in onednn #64300

Merged
merged 9 commits into from
May 20, 2024

Conversation

changeyoung98
Copy link
Contributor

@changeyoung98 changeyoung98 commented May 14, 2024

PR Category

Others

PR Types

Others

Description

pcard-67164
Fix save_load bf16 bug in onednn

  • bf16单测中使用amp的static旧API,新IR下需要使用动静统一API重写单测
  • 旧测试传入的数据类型为uint16,在旧测试下是为了规避slice的问题,新IR下反而会造成问题,因此将数据类型改为float32
  • 组网中遇到sgd.minimize的问题,震哥已修复
  • 执行中遇到bf16类型kernel选择问题,分别有kernel为onednn但layout未修改以及layout为onednn但kernel type不为onednn的情况,欢哥已修复。

Copy link

paddle-bot bot commented May 14, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changeyoung98 changeyoung98 merged commit a907252 into PaddlePaddle:develop May 20, 2024
31 checks passed
@changeyoung98 changeyoung98 deleted the czy-bf16 branch May 20, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants