[CINN][New Hardware Update] extend SplitCudaAndHostModule #64345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename SplitCudaAndHostModule to SplitDeviceAndHostModule
|
你的PR提交成功，感谢你对开源项目的贡献! |
DongBaiYue
changed the title
tc20042008
reviewed
May 16, 2024
| @@ -121,9 +133,19 @@ struct CollectHostFunctionVisitor : public ir::IRMutator<> { | |||
| << func->cuda_axis_info.block_dim(1) << ", " | |||
| << func->cuda_axis_info.block_dim(2) << "), " | |||
| << "shared_mem: " << shared_mem_bytes; | |||
|
|
|||
| const char* call_kernel; | |||
There was a problem hiding this comment.
const char* call_kernel = nullptr;
基本数据类型总是需要默认值。
或者更加现代c++的感觉：
std::optional<const char*> call_kernel;| @@ -91,7 +91,16 @@ void detail::CollectBucketStrategyHostFunctionVisitor::ProcessLoweredFunc( | |||
| ir::Var kernel_ptr(GenDeviceKernelName(func_node->name, predicate), | |||
| type_of<std::string>()); | |||
|
|
|||
| Expr shared_mem_bytes = CalculateSharedMemory(func); | |||
| Expr shared_mem_bytes; | |||
There was a problem hiding this comment.
std::optional shared_mem_bytes;
| cinn::common::DefaultNVGPUTarget()) {} | ||
| device_module_builder( | ||
| module_name + "_gpu_device", | ||
| cinn::runtime::CurrentTarget::GetCurrentTarget()) {} |
There was a problem hiding this comment.
这些改动没有遵守平迁原则。cinn::common::DefaultNVGPUTarget 和cinn::runtime::CurrentTarget::GetCurrentTarget 是啥关系呢？如果是替换，那应该在别的pr里完成。
就算要同时迁移这里的逻辑，与旧版cinn::common::DefaultNVGPUTarget对应的名字难道不是cinn::common::DefaultDeviceTarget吗？
| @@ -101,9 +110,17 @@ void detail::CollectBucketStrategyHostFunctionVisitor::ProcessLoweredFunc( | |||
| << func_node->cuda_axis_info.block_dim(1) << ", " | |||
| << func_node->cuda_axis_info.block_dim(2) << "), " | |||
| << "shared_mem: " << shared_mem_bytes; | |||
| const char *call_kernel; | |||
| cinn::runtime::CurrentTarget::GetCurrentTarget().arch.Match( | |||
There was a problem hiding this comment.
cinn::runtime::CurrentTarget::GetCurrentTarget这个名字非常拧巴。原本的命名空间是cinn::common::，为啥不继续写在common目录下呢？
tc20042008
approved these changes
May 16, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 18, 2024
…le#64345) * [CINN][New Hardware Update] rename SplitCudaAndHostModule * rename SplitCudaAndHostModule to SplitDeviceAndHostModule * [CINN][New Hardware Update] fix CMakeLists * [CINN][New Hardware Update] extend SplitDeviceAndHostModule * fix review
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
May 19, 2024
…le#64345) * [CINN][New Hardware Update] rename SplitCudaAndHostModule * rename SplitCudaAndHostModule to SplitDeviceAndHostModule * [CINN][New Hardware Update] fix CMakeLists * [CINN][New Hardware Update] extend SplitDeviceAndHostModule * fix review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
扩展SplitCudaAndHostModule为SplitDeviceAndHostModule，以复用在其他device后端上。
DefaultNVGPUTarget -> DefaultDeviceTarget，后者是前者的超集。
pcard-79890