[Typing][A-8] Add type annotations for python/paddle/tensor/math.py
#65073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
DrRyanHuang
reviewed
Jun 12, 2024
Comment on lines
+98
to
+99
| if TYPE_CHECKING: | ||
| from paddle import Tensor |
There was a problem hiding this comment.
之后的PR都这样吗? 不用 paddle.Tensor 了吗
There was a problem hiding this comment.
都可以，这样可以省去每次都写 paddle.Tensor，两者对于 type checker 是等价的
这里使用 TYPE_CHECKING 是为了避免运行时产生 circular import，高层次模块不必如此，直接 import 即可
2024-06-12 18:16:28 <string>:4:22: error: Argument 1 to "to_tensor" has incompatible type "List[object]"; expected "Union[Union[ndarray[Any, dtype[Any]], Tensor, Union[int, float, complex, number[Any], Tensor]], NestedNumbericSequence]" [arg-type]
# input = [[[2.0, 2, -2], [3, 0.3, 3]], [[2, -8, 2], [3.1, 3.7, 3]]] 有问题
input = [[[2.0, 2., -2.], [3., 0.3, 3.]], [[2., -8., 2.], [3.1, 3.7, 3.]]] 可以
to_tensor(input)这个地方，我觉得不用改 第一种属于不太规范，也不提倡 ～ @SigureMo 觉得呢？ |
嗯，这样是更合适的 |
SigureMo
changed the title
python/paddle/tensor/math.pypython/paddle/tensor/math.py
zrr1999
approved these changes
Jun 13, 2024
SigureMo
changed the title
python/paddle/tensor/math.pypython/paddle/tensor/math.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
Add type annotations for
python/paddle/tensor/math.pyNeed #64954
Related links
PCard-66972