[Prim][PIR] Support dynamic shape for concat_grad #65148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
zeroRains
requested review from
Aurelius84,
cxxly,
xiaoguoguo626807 and
changeyoung98
as code owners
| for (int i = 0; i < x_num; ++i) { | ||
| sections.push_back(x[i].dims()[axis_value]); | ||
| std::vector<Tensor> x_grad_tmp; | ||
| if (has_dynamic_shape(x[0].shape())) { |
There was a problem hiding this comment.
这个地方逻辑不够完善，下一个pr完善一下，并补充相关单侧。
There was a problem hiding this comment.
- 拆解逻辑这块是指对vector x中的每个tensor都要进行动态shape的判断么？
- 补充单侧的输入一部分tensor是静态shape，一部分tensor是动态shape这样子么？
| if (has_dynamic_shape(x[0].shape())) { | ||
| std::vector<Tensor> sections; | ||
| for (int i = 0; i < x_num; i++) { | ||
| sections.push_back(slice<T>(shape<T>(x[i]), |
There was a problem hiding this comment.
前向拆解里封装了get_slice接口，建议这里复用
zyfncg
approved these changes
Jun 18, 2024
co63oc
pushed a commit
to co63oc/Paddle
that referenced
this pull request
Jun 25, 2024
* support dynamic shape for cocnat_grad and add the dynamic shape test for split_grad * fix the bug in detail.h and the test case * add the allow_dynamic_shape
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
New features
Description
为concat_grad添加动态shape支持，添加split_grad动态shape的单测