-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine docker install doc and FAQ for gpu driver #663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the conflicts of this PR are due to the recent merging of my PRs that change docker-install.rst
. And I noticed that I didn't change the Chinese version of docker-install.rst
. I will update in another PR.
It seems that we need to resolve some conflicts. To make this easier, please feel free to accept my changes (which has been on upstream/develop) to the English and Chinese version docker_install.rst
, and just add your changes on faq/index.rst and hl_cuda_cnn.cu.
atomicAdd(&inPos[wId], h2lambda * w1lambda * outPos[0]); | ||
atomicAdd(&inPos[hId * inImgW], h1lambda * w2lambda * outPos[0]); | ||
atomicAdd(&inPos[hId * inImgW + wId], h1lambda * w1lambda * outPos[0]); | ||
paddle::paddleAtomicAdd(&inPos[0], h2lambda * w2lambda * outPos[0]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
既然已经定义在 paddle namespace 里了,函数名字还需要加paddle前缀吗?
是不是应该提一个issue,记录一下修改改成 paddle::atomicAdd
,甚至 paddle::atomic::add
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修改成paddle::atomicAdd
是不合适的,cuda本身有atomicAdd
函数。如果在using namespace paddle之后使用, 容易混淆。
之所以包一层的原因是为了支持不同的cuda版本,随着cuda版本的升级,NVIDIA才陆续支持atomicAdd double版,6.5之前的版本是我们自己手写的atomicAdd double版本。写成paddle::atomic::add
感觉好一些。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wangkuiyi 这个atomic下一个PR改吧
when merge with the develop branch, some mistakes happened
|
||
- Dockerfile:Docker Image的描述文件,包括构建步骤、各种参数和维护人员等。 | ||
|
||
- 一共维护了12个Dockerfile,Dockerfile.m4是它们的模板。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个文档已经outofdate了。需要修改
* Update cn api to 1.3 fluid & layers * Rest to 1.3
* synchronize with develop (PaddlePaddle#642) * update_commitid1.3 (PaddlePaddle#641) * update inference c++ API doc (PaddlePaddle#634) * update inference c++ API doc * fix link * thorough clean for doc (PaddlePaddle#644) * thorough clean * delete_DS_Store * Cherrypick1.3 (PaddlePaddle#652) * thorough clean * delete_DS_Store * [Don't merge now]update_install_doc (PaddlePaddle#643) * update_install_doc * follow_comments * add maxdepth (PaddlePaddle#646) * upload_md (PaddlePaddle#649) * update_version (PaddlePaddle#650) * Translation of 16 new apis (PaddlePaddle#651) * fix_windows * Final update 1.3 (PaddlePaddle#653) * thorough clean * delete_DS_Store * update_1.3 * Deadlink fix (PaddlePaddle#654) * fix_deadlinks * update_docker * Update release_note.rst * Update index_cn.rst * update_Paddle (PaddlePaddle#658) * fix pic (PaddlePaddle#659) * [to 1.3] cn api debug (PaddlePaddle#655) (PaddlePaddle#661) * debug * fix 2 -conv2d * "锚" ==> anchor(s) * Weekly cherrypick0302 (PaddlePaddle#668) * Update programming_guide.md (PaddlePaddle#664) * Update programming_guide.md * Update programming_guide_en.md * Update cn api to 1.3 (PaddlePaddle#663) * Update cn api to 1.3 fluid & layers * Rest to 1.3 * Weeklyupdate 0301 (PaddlePaddle#666) * Tables_rm_op * update_op * update_index * update_book_0302 (PaddlePaddle#667) * fix_format (PaddlePaddle#669) (PaddlePaddle#670) * fix_format * Update Tables.md * Update Tables_en.md * add dataset api_cn (PaddlePaddle#673) * rm fluid.core in desigin_idea (PaddlePaddle#674) * Update fluid_design_idea.md * Update fluid_design_idea_en.md * Fix array_read code example error. (PaddlePaddle#671) Signed-off-by: zhaoyuchen <zhaoyuchen01@baidu.com> * add data_reader_cn (PaddlePaddle#676) * fix doc error (PaddlePaddle#675) * update_book_commitid (PaddlePaddle#680) * update_book_commitid * commitid0309 * fix typo * book indexes (PaddlePaddle#677)
change the path of ernie-gram and fix mrc
* feat: add BART model * fix: fix BartForSequenceClassification with new sentence_representation * feat: add pretrained models and vocab * refactor: update copyright notice * refactor: rename encoder_layers to num_encoder_layers * feat: add cache for BartDecoder Co-authored-by: Zeyu Chen <chenzeyu01@baidu.com>
…-ipu_bfd54663b9bb97a3653dee75fded84e3212802ba [AUTO PR] Pulling [develop] into [develop-ipu] [2022-04-22 03:05:05+08:00]
#633 #656