[SOT][dynamic shape] Use guard value instead of raise_break_graph_fn to call int/float #66346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
Sorry to inform you that 0863104's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
Sorry to inform you that f4200a6's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
SigureMo
approved these changes
Aug 28, 2024
| @@ -58,7 +58,7 @@ class OpcodeExecutorCache(metaclass=Singleton): | |||
| MAX_CACHE_SIZE = 20 | |||
| cache: dict[types.CodeType, GuardedFunctions] | |||
| translate_count: int | |||
| code_symbolic_inputs: dict[types.CodeType, dict[str, dict[int, int]]] | |||
| code_symbolic_inputs: dict[types.CodeType, dict[str, None | dict[int, int]]] | |||
| @@ -714,6 +715,18 @@ def __bool__(self) -> bool: | |||
| def bool(self): | |||
| return ConstantVariable(bool(self), self.graph, DummyTracker([self])) | |||
|
|
|||
| def __int__(self) -> int: | |||
There was a problem hiding this comment.
__int__ 和 __float__ 后续使用时要注意，不带 Tracker，可能会导致 guard 缺失的问题
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Performance
Description
Use guard value instead of raise_break_graph_fn to call int/float