Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typing][C-90] Add type annotation for python/paddle/incubate/operators/resnet_unit.py #66793

Merged
merged 8 commits into from
Aug 3, 2024

Conversation

inaomIIsfarell
Copy link
Contributor

@inaomIIsfarell inaomIIsfarell commented Jul 30, 2024

PR Category

User Experience

PR Types

Improvements

Description

类型标注:

  • python/paddle/incubate/operators/resnet_unit.py

Related links

@SigureMo @megemini

Copy link

paddle-bot bot commented Jul 30, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@megemini megemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResNetUnitforward 漏掉了 ~

bias_x: Tensor,
mean_x: Tensor,
var_x: Tensor,
z: str | None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
z: str | None,
z: Tensor | None,

Copy link
Contributor

@megemini megemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResNetUnitforward 漏掉了 ~

@luotao1 luotao1 added contributor External developers HappyOpenSource 快乐开源活动issue与PR labels Jul 30, 2024
Copy link
Contributor

@megemini megemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ~

@SigureMo
Copy link
Member

SigureMo commented Aug 3, 2024

标题以后自己改

-[Typing][C-90]Add type annotation for ```python/paddle/incubate/operators/resnet_unit.py```
+[Typing][C-90] Add type annotation for `python/paddle/incubate/operators/resnet_unit.py`

@SigureMo SigureMo changed the title [Typing][C-90]Add type annotation for python/paddle/incubate/operators/resnet_unit.py [Typing][C-90] Add type annotation for python/paddle/incubate/operators/resnet_unit.py Aug 3, 2024
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo merged commit 6a09fa4 into PaddlePaddle:develop Aug 3, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants