[Typing][PEP585 Upgrade][2-3] Use standard collections for type hints in paddle/fluid/operators/generator/*
#66968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
gouzil
previously approved these changes
Aug 2, 2024
SigureMo
reviewed
Aug 2, 2024
Comment on lines
20
to
21
| if TYPE_CHECKING: | ||
| from collections.abc import Sequence |
There was a problem hiding this comment.
不要插在 import 中间，这会影响 isort，要放在 import 区域之后
你这样会使得 import 分成三部分，这不是我们所预期的
# import section1, sorted
# if type checking
# import section3, sorted
# import section2, sorted预期的是：
# import section1, sorted
# if type checking
# import section2, sorted因此 if TYPE_CHECKING 统一放在其他 import 之后
SigureMo
changed the title
paddle/fluid/operators/generator/*paddle/fluid/operators/generator/*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Devs
Description
为如下文件添加 PEP 563，并进行 PEP 585 升级：
paddle/fluid/operators/generator/filters.pypaddle/fluid/operators/generator/parse_utils.pyRelated links