Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typing][PEP585 Upgrade][BUAA][11-20] Use standard collections for type hints for 8 files in python/paddle/ #67096

Merged
merged 10 commits into from
Aug 7, 2024

Conversation

Caogration
Copy link
Contributor

PR Category

User Experience

PR Types

Devs

Description

为如下文件添加 PEP 563,并进行 PEP 585 升级:

  • python/paddle/audio/backends/init_backend.py (无需修改)
  • python/paddle/audio/backends/wave_backend.py (无需修改)
  • python/paddle/audio/datasets/dataset.py
  • python/paddle/audio/datasets/esc50.py
  • python/paddle/audio/datasets/tess.py
  • python/paddle/audio/functional/window.py
  • python/paddle/autograd/autograd.py
  • python/paddle/autograd/backward_mode.py
  • python/paddle/autograd/py_layer.py
  • python/paddle/base/dygraph/base.py

Related links

@gouzil

Copy link

paddle-bot bot commented Aug 6, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 contributor External developers labels Aug 6, 2024
gouzil
gouzil previously approved these changes Aug 6, 2024
Co-authored-by: Nyakku Shigure <sigure.qaq@gmail.com>
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo SigureMo changed the title [Typing][PEP585 Upgrade][BUAA][11-20] Use stardand collections for type hints in python/paddle/* [Typing][PEP585 Upgrade][BUAA][11-20] Use standard collections for type hints in python/paddle/* Aug 6, 2024
@SigureMo SigureMo changed the title [Typing][PEP585 Upgrade][BUAA][11-20] Use standard collections for type hints in python/paddle/* [PEP585 Upgrade][BUAA][11-20] Use standard collections for type hints in python/paddle/* Aug 6, 2024
@SigureMo SigureMo changed the title [PEP585 Upgrade][BUAA][11-20] Use standard collections for type hints in python/paddle/* [PEP585 Upgrade][BUAA][11-20] Use standard collections for type hints for 8 files in python/paddle/ Aug 6, 2024
@SigureMo SigureMo changed the title [PEP585 Upgrade][BUAA][11-20] Use standard collections for type hints for 8 files in python/paddle/ [Typing][PEP585 Upgrade][BUAA][11-20] Use standard collections for type hints for 8 files in python/paddle/ Aug 6, 2024
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-08-07 05:34:50 ++ python type_checking.py --debug
2024-08-07 05:34:50 ----------------Check results--------------------
2024-08-07 05:34:50 paddle.autograd.jacobian:1
2024-08-07 05:34:50 <string>:10:7: error: Item "Tuple[Jacobian, ...]" of "Union[Tuple[Jacobian, ...], Any]" has no attribute "shape"  [union-attr]
2024-08-07 05:34:50 <string>:11:7: error: Item "Tuple[Jacobian, ...]" of "Union[Tuple[Jacobian, ...], Any]" has no attribute "shape"  [union-attr]
2024-08-07 05:34:50 Found 2 errors in 1 file (checked 1 source file)

@SigureMo @megemini 这个是PR问题还是检测工具问题呀

@SigureMo
Copy link
Member

SigureMo commented Aug 7, 2024

@SigureMo @megemini 这个是PR问题还是检测工具问题呀

文件没推全,那边的 B-38 任务,这个任务不涉及,豁免下吧

@luotao1 luotao1 merged commit 5f2a4b0 into PaddlePaddle:develop Aug 7, 2024
31 checks passed
@Caogration Caogration deleted the PEP585_Upgrade_2 branch August 7, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants