[Infer Symbolic Shape No.161,162][BUAA] norm, p_norm
#67136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
|
luotao1
added
contributor
gongshaotian
reviewed
Aug 8, 2024
| int axis = op->attribute<pir::Int32Attribute>("axis").data(); | ||
| bool is_test = op->attribute<pir::BoolAttribute>("is_test").data(); | ||
|
|
||
| if (!is_test) { |
There was a problem hiding this comment.
🎉恭喜遇到一个不明参数，这个参数在api文档里没有，但yaml文件里声明了，一般是用来区分训练和推理的，is_test开着代表是跑推理，麻烦下周会跟同学们分享下
gongshaotian
reviewed
Aug 8, 2024
| if (!is_test) { | ||
| if (axis < 0) axis += x_shape.size(); | ||
|
|
||
| auto norm_shape = x_shape; |
There was a problem hiding this comment.
我后来看了一下好像是因为 x_shape 被加了 const 标记，所以需要 copy 一份才能进行相关修改，泓清老师说这里保留原样不用修改了。
gongshaotian
reviewed
Aug 8, 2024
| auto x_shape_or_data = | ||
| infer_context->GetShapeOrDataForValue(op->operand_source(0)); | ||
| const auto &x_shape = x_shape_or_data.shape(); | ||
| auto x_rank = x_shape.size(); |
gongshaotian
reviewed
Aug 8, 2024
|
|
||
| bool PNormOpInferSymbolicShape(pir::Operation *op, | ||
| pir::InferSymbolicShapeContext *infer_context) { | ||
| auto x_shape_or_data = |
gongshaotian
reviewed
Aug 8, 2024
| "Current Input(X)'s shape is=[%s].", | ||
| axis, | ||
| x_rank, | ||
| x_shape)); |
There was a problem hiding this comment.
这么写有点丑，能不能把下面的axis 取正数放前面来，然后修改一下这两个断言
gongshaotian
reviewed
Aug 8, 2024
| x_rank, | ||
| x_shape)); | ||
|
|
||
| std::vector<symbol::DimExpr> out_dim_vector; |
There was a problem hiding this comment.
有歧义，out_shape还是out_data
gongshaotian
reviewed
Aug 8, 2024
|
|
||
| if (keepdim) { | ||
| for (size_t i = 0; i < x_rank; ++i) { | ||
| if (static_cast<int>(i) == axis) { |
gongshaotian
reviewed
Aug 8, 2024
| } | ||
| } else { | ||
| for (size_t i = 0; i < x_rank; ++i) { | ||
| if (static_cast<int>(i) != axis) { |
38 tasks
|
LGTM |
luotao1
approved these changes
Aug 13, 2024
Jeff114514
pushed a commit
to Jeff114514/Paddle
that referenced
this pull request
Aug 14, 2024
…e#67136) * Finished norm and p_norm * Fixed name errors * Removed unused variables * Updated norm and pnorm in unary_infer_sym.cc according to suggested changes * Removed comments * Fixed errors returned by CI * Put some old code back * Use a bool variable to make life easier
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Others
Description
添加
norm和p_norm两个中等难度的算子的符号推导接口实现。