[Typing][C-25/26, C-[40-44], C-83][BUAA] Add type annotations for 7 files in python/paddle/distributed/{communication/fleet} and 1 file in python/paddle/incubate #67203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
luotao1
added
contributor
This was referenced Aug 9, 2024
|
请求approve！ |
megemini
reviewed
Aug 12, 2024
There was a problem hiding this comment.
问题比较多，先总体修改一遍再 review 吧 ～
另外，这里面文件中需要标注的接口：
- python/paddle/distributed/fleet/base/distributed_strategy.py : DistributedStrategy
- python/paddle/distributed/fleet/base/role_maker.py : PaddleCloudRoleMaker, Role, UserDefinedRoleMaker
- python/paddle/distributed/fleet/base/topology.py : CommunicateTopology, HybridCommunicateGroup, ParallelMode
- python/paddle/distributed/fleet/base/util_factory.py : UtilBase
- python/paddle/distributed/fleet/data_generator/data_generator.py : MultiSlotDataGenerator, MultiSlotStringDataGenerator
如果是类，则标注类的公开接口、实例参数以及必要的魔法方法（如 init 等)
如果无法确定哪些接口需要标注，可以查看模块下面 __init__.py 中 __all__ 的引用关系 ～
还有，PR 需要根据模板样式提交，不然无法及时 review
There was a problem hiding this comment.
几个问题
- 这个文件只有
DistributedStrategy需要标注，其他的函数不需要标注 - 不要都使用
object或者Any，分析一下输入输出类型 - 泛型需要参数化，不要只使用
dict, list等
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Others
Description
完成了Typehint标注：
modified: python/paddle/distributed/communication/stream/all_reduce.py
modified: python/paddle/distributed/communication/stream/all_to_all.py
modified: python/paddle/distributed/fleet/base/distributed_strategy.py
modified: python/paddle/distributed/fleet/base/role_maker.py
modified: python/paddle/distributed/fleet/base/topology.py
modified: python/paddle/distributed/fleet/base/util_factory.py
modified: python/paddle/distributed/fleet/data_generator/data_generator.py
modified: python/paddle/incubate/nn/layer/fused_ec_moe.py(冲突，被修改，已修复)