feature/parallel_do #6730
feature/parallel_do #6730
Conversation
paddle/framework/lod_tensor.h
Outdated
| @@ -144,6 +144,9 @@ class LoDTensor : public Tensor { | |||
| */ | |||
| void ShrinkInLevel(size_t level, size_t elem_begin, size_t elem_end); | |||
|
|
|||
| void MergeLoDTensor(const std::vector<const LoDTensor*>& lod_tensors, | |||
There was a problem hiding this comment.
Do we need to add comments about this function?
| } else if (var->IsType<SelectedRows>()) { | ||
| t = &(var->Get<SelectedRows>().value()); | ||
| } else { | ||
| PADDLE_THROW("Variable type must be LoDTensor/SelectedRows."); | ||
| PADDLE_THROW("Variable type_id %s, expect LoDTensor/SelectedRows.", |
There was a problem hiding this comment.
expect LoDTensor/SelectedRows => expect LoDTensor/SelectedRows/Tensor?
There was a problem hiding this comment.
This is a leftover from debugging. Sorry for the confusion.
| } else if (var->IsType<SelectedRows>()) { | ||
| t = var->GetMutable<SelectedRows>()->mutable_value(); | ||
| } else { | ||
| PADDLE_THROW("Variable type must be LoDTensor/SelectedRows."); | ||
| PADDLE_THROW("Variable type_id %s, expect LoDTensor/SelectedRows.", |
There was a problem hiding this comment.
expect LoDTensor/SelectedRows => expect LoDTensor/SelectedRows/Tensor?
There was a problem hiding this comment.
This is a leftover from debugging. Sorry for the confusion.
| } else if (var->IsType<SelectedRows>()) { | ||
| return var->Get<SelectedRows>().GetCompleteDims(); | ||
| } else { | ||
| PADDLE_THROW("Variable type must be LoDTensor/SelectedRows."); | ||
| PADDLE_THROW("Variable %s type_id %s, expect LoDTensor/SelectedRows.", |
There was a problem hiding this comment.
This is a leftover from debugging. Sorry for the confusion.
| } else if (var->IsType<SelectedRows>()) { | ||
| var->GetMutable<SelectedRows>()->set_height(dim[0]); | ||
| } else { | ||
| PADDLE_THROW("Variable type must be LoDTensor/SelectedRows."); | ||
| PADDLE_THROW("Variable %s type_id %s, expect LoDTensor/SelectedRows.", |
There was a problem hiding this comment.
This is a leftover from debugging. Sorry for the confusion.
paddle/framework/operator.cc
Outdated
| @@ -179,10 +179,13 @@ static const Tensor* GetTensorFromVar(const Variable* var) { | |||
| const Tensor* t = nullptr; | |||
| if (var->IsType<LoDTensor>()) { | |||
| t = &(var->Get<LoDTensor>()); | |||
| } else if (var->IsType<Tensor>()) { | |||
There was a problem hiding this comment.
A little confused about it: do the ParallelDo operator need it?
There was a problem hiding this comment.
This is a leftover from debugging. Sorry for the confusion.
paddle/operators/parallel_do_op.cc
Outdated
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ |
There was a problem hiding this comment.
The license format is not correct, please refer to #7022
fix #6637
depends on: #6728