【Hackathon 7th No.20】为 Paddle 新增 Tensor.resize_ -part #69841
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
test_inplace (Failed) |
test/legacy_test/test_inplace.py
Outdated
| or not paddle.base.core.is_float16_supported(paddle.CUDAPlace(0)), | ||
| "core is not compiled with CUDA and not support the float16", | ||
| ) | ||
| class TestDygraphInplaceResizeP16(TestDygraphInplaceResize): |
| fill_zero (bool, optional): If the size of specified ``shape`` is greater than the original Tensor size, the | ||
| new Tensor will be filled with zero if ``fill_zero`` is True. Default: False, which means the filled value | ||
| will be undetermined. | ||
| name (str|None, optional): Name for the operation (optional, default is None). For more information, please refer to :ref:`api_guide_Name`. |
There was a problem hiding this comment.
Where did this parameter come from?
There was a problem hiding this comment.
To make the functionality aligned with numpy (when calling ndarray.resize() )
There was a problem hiding this comment.
Then you should add this parameter to interface?
There was a problem hiding this comment.
Then you should add this parameter to interface?
Do you mean I should not add this parameter and functionality to the interface?
There was a problem hiding this comment.
your interface have three inputs, but doc get four?
There was a problem hiding this comment.
oh I forgot to include the parameter name.
added.
| 'complex128', | ||
| ], | ||
| 'resize', | ||
| ) |
There was a problem hiding this comment.
miss data format check for shape
There was a problem hiding this comment.
also converge this codes in unit test?
There was a problem hiding this comment.
covered here for shape data format check.
PR Category
User Experience
PR Types
New features
Description