Adam selectedrows and scatter functors #7045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
reviewed
Dec 27, 2017
paddle/operators/adam_op.h
Outdated
| T mom2 = moment2_[rows_[i] * row_numel_ + j]; | ||
| T lr = *lr_; | ||
| T beta1_pow = *beta1_pow_; | ||
| T beta2_pow = *beta2_pow_; |
There was a problem hiding this comment.
T lr = *lr_;
T beta1_pow = *beta1_pow_;
T beta2_pow = *beta2_pow_;
For GPU, these operations are always call the data from memory to register?
QiJune
reviewed
Dec 27, 2017
paddle/operators/adam_op.h
Outdated
| mom2 = beta2_ * mom2 + (1 - beta2_) * g * g; | ||
| p -= lr * (mom1 / (sqrt(mom2) + epsilon_)); | ||
| // IMPORTANT: | ||
| // FIXME(typhoonzero): row id may be duplicate |
There was a problem hiding this comment.
Sparse Adagrad merges row id first. Please refer to https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/operators/adagrad_op.cc#L107.
There was a problem hiding this comment.
Thanks! Will update this.
typhoonzero
changed the title
typhoonzero
changed the title
QiJune
approved these changes
Dec 29, 2017
| if (tid == 0) { | ||
| for (size_t i = 0; i < out_rows_size; i++) { | ||
| if (input_rows[ty] == out_rows[i]) { | ||
| out_idx = i; |
There was a problem hiding this comment.
Sure. I'll try to fix in next PR since I'm considering a way to simplify the functors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7019
Start: 2017.12.27
Due: 2018.1.3