Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThreadPool::Run interface return std::future #7099

Merged
merged 2 commits into from
Dec 28, 2017
Merged

ThreadPool::Run interface return std::future #7099

merged 2 commits into from
Dec 28, 2017

Conversation

Yancey1989
Copy link
Contributor

Fixed #7040

@Yancey1989 Yancey1989 changed the title Run interface return future ThreadPool::Run interface return std::future Dec 28, 2017
reyoung
reyoung reviewed Dec 28, 2017
View reviewed changes
paddle/framework/threadpool.h Outdated
@@ -25,10 +26,14 @@ limitations under the License. */
namespace paddle {
namespace framework {

typedef std::function<void()> Task;
// typedef std::packaged_task<void()> Task;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove them.

reyoung
reyoung previously approved these changes Dec 28, 2017
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@Yancey1989 Yancey1989 merged commit 5022ee6 into PaddlePaddle:develop Dec 28, 2017
@Yancey1989 Yancey1989 deleted the future_wait branch December 28, 2017 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyoung reyoung reyoung approved these changes

@typhoonzero typhoonzero Awaiting requested review from typhoonzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yancey1989 @reyoung