Enhence shrink_rnn_memory_op. #7176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
reviewed
Jan 4, 2018
|
|
||
| // should consider multiple levels | ||
| size_t height = dst_num_rows; | ||
| auto lod_level = rank_table.level(); |
There was a problem hiding this comment.
rank_table.level() is not related to ShrinkMemory.
Also, lod_level must always be zero? Since you cannot shrink the fine level of LoD without shrink the coarse level of LoD.
There was a problem hiding this comment.
Thanks, follow comments.
reyoung
reviewed
Jan 4, 2018
| framework::AppendLoD(&remain, lod_offset.first); | ||
| for (size_t j = 0; j < remain.size(); ++j) { | ||
| out_lod->emplace_back(remain[j]); | ||
| } |
There was a problem hiding this comment.
This logic is too complex. Since we just shrink the first level of LoD, we can just drop the last N element of the LoD.
pkuyym
commented
Jan 4, 2018
|
|
||
| // should consider multiple levels | ||
| size_t height = dst_num_rows; | ||
| auto lod_level = rank_table.level(); |
There was a problem hiding this comment.
Thanks, follow comments.
| framework::AppendLoD(&remain, lod_offset.first); | ||
| for (size_t j = 0; j < remain.size(); ++j) { | ||
| out_lod->emplace_back(remain[j]); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7173