Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CopyFrom to Copy for tensors #7292

Merged
merged 4 commits into from
Jan 9, 2018
Merged

Rename CopyFrom to Copy for tensors #7292

merged 4 commits into from
Jan 9, 2018

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jan 8, 2018 •
edited
Loading

We have a global function named CopyFrom. It is a bad name.
Either dst.CopyFrom(src) or Copy(dst, src) is fine. Since we prefer to use global functions, just rename CopyFrom to Copy.

@reyoung reyoung changed the title Rename Tensor::CopyFrom to Tensor::Copy Rename CopyFrom to Copy for tensors Jan 9, 2018
tonyyang-svail
tonyyang-svail approved these changes Jan 9, 2018
View reviewed changes
Copy link

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@tonyyang-svail tonyyang-svail merged commit ce6dad3 into PaddlePaddle:develop Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyyang-svail tonyyang-svail tonyyang-svail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @tonyyang-svail