Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add distributed label semantic role book chapter #7425

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Add distributed label semantic role book chapter #7425

merged 1 commit into from
Jan 11, 2018

Conversation

helinwang
Copy link
Contributor

Fixes: #7424

@Yancey1989
Copy link
Contributor

Thanks for PR, please fix the Travis-ci failed.

typhoonzero
typhoonzero reviewed Jan 11, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can merge when the traivis ci fixed.

@helinwang helinwang force-pushed the distributed_label_semantic_role branch from f0d9d37 to 6c07236 Compare January 11, 2018 19:17
putcn
putcn approved these changes Jan 11, 2018
View reviewed changes
Copy link
Contributor

@putcn putcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helinwang helinwang merged commit bfc68f2 into PaddlePaddle:develop Jan 11, 2018
@helinwang helinwang deleted the distributed_label_semantic_role branch January 11, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero left review comments

@putcn putcn putcn approved these changes

@Yancey1989 Yancey1989 Awaiting requested review from Yancey1989

@gongweibao gongweibao Awaiting requested review from gongweibao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@helinwang @Yancey1989 @putcn @typhoonzero