Add one_hot operator. #7819
Merged
Add one_hot operator. #7819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
reviewed
Jan 24, 2018
| depth)).astype('float32') | ||
|
|
||
| for i in xrange(np.product(x.shape)): | ||
| out[i, x[i]] = 1.0 |
There was a problem hiding this comment.
for i in xrange(np.product(x.shape)):
out[i, x[i]] = 1.0
==>
out[range(0,x_lod[0][-1]),x] = 1.0
There was a problem hiding this comment.
Thanks, but I think current implement is ok.
paddle/operators/one_hot_op.cc
Outdated
| "The tensor consists of one-hot representations of values in X."); | ||
| AddAttr<int>("depth", | ||
| "An integer to specify the length of one-hot vector."); | ||
| AddAttr<int>("dtype", |
There was a problem hiding this comment.
Shouldn't we provide a default type over here?
| PADDLE_ENFORCE_GE(x_dims[x_dims.size() - 1], 1U, | ||
| "Last dimension of Input(X) should be 1."); | ||
|
|
||
| int depth = ctx->Attrs().Get<int>("depth"); |
There was a problem hiding this comment.
I think we should enforce that a positive depth is provided.
| import paddle.v2.fluid.core as core | ||
|
|
||
|
|
||
| class TestOneHotOp(OpTest): |
There was a problem hiding this comment.
It will also help to have some negative examples, where the depth is less than the index values. We can catch the exception thrown by the executor to make sure that the code gives an error for such faulty cases.
There was a problem hiding this comment.
Thanks, have added more unit test.
This was referenced Feb 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7740