Add Python interface of prior_boxes #8265

chengduoZH · 2018-02-08T07:32:37Z

fix #8333
related issue #7488

qingqing01 · 2018-02-09T12:20:15Z

python/paddle/v2/fluid/layers/nn.py

@@ -64,7 +66,11 @@
    'nce',
    'beam_search',
    'row_conv',
+    'reshape',


reshape has been exposed to Python in https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/v2/fluid/layers/ops.py#L50

qingqing01 · 2018-02-09T12:21:08Z

python/paddle/v2/fluid/layers/nn.py

+    return box, var
+
+
+def prior_boxes(input_layers,


I think only prior_boxes is enough. the definition of prior_box can be moved this function.

CLAassistant · 2018-02-10T06:38:50Z

All committers have signed the CLA.

… feature/add_prior_box_py

qingqing01 · 2018-02-11T08:23:40Z

python/paddle/v2/fluid/layers/nn.py

@@ -3091,3 +3096,295 @@ def multiplex(inputs, index):
                'Ids': index},
        outputs={'Out': [out]})
    return out
+
+
+def reshape_with_axis(input, axis):


我觉得不需要封装这个接口给用户，一个reshape足够了，类似这样的接口用户可以自己封装，不需要Fluid官方提供。

qingqing01 · 2018-02-11T08:25:10Z

python/paddle/v2/fluid/layers/nn.py

+        type='reshape',
+        inputs={'X': [input]},
+        outputs={'Out': [out]},
+        attrs={'shape': new_shape})


out = layers.reshape(input, shape=new_shape)

I think flatten is a common function and Fluid should have it.

qingqing01 · 2018-02-11T08:26:45Z

python/paddle/v2/fluid/layers/nn.py

+        max_sizes = [base_size * .20] + max_sizes
+
+    if step_h:
+        assert isinstance(step_h,list) and len(step_h) == num_layer, \


assert -> raise ValueError('xxx')

pkuyym · 2018-02-09T12:16:06Z

python/paddle/v2/fluid/layers/nn.py

+          reshaped.shape
+            >> [-1, 96, 32]
+    """
+    assert isinstance(axis, list), "axis should be list."


Please raise a ValueError instead.

I have removed this function.

pkuyym · 2018-02-11T09:21:47Z

python/paddle/v2/fluid/layers/nn.py

+            >> [-1, 1024]
+    """
+    assert len(input.shape) > axis and axis > 0, \
+        "the axis should be litter than input.shape's."


litter --> smaller
input.shape's --> arity of input's shape

pkuyym · 2018-02-11T09:22:09Z

python/paddle/v2/fluid/layers/nn.py

+    be two-dimension. The axis is used to indicate where to split the dimension.
+
+    Args:
+       input(variable): The input tensor.


input(variable) --> input (Variable)

pkuyym · 2018-02-11T09:23:59Z

python/paddle/v2/fluid/layers/detection.py

+    """
+    **Prior_boxes**
+
+    Generate prior boxes for SSD(Single Shot MultiBox Detector) algorithm.


This comment is a little obscure, please refine it.

pkuyym · 2018-02-11T09:24:12Z

python/paddle/v2/fluid/layers/detection.py

+
+    Args:
+       inputs(list): The list of input variables, the format of all variables is NCHW.
+       image(variable): The input image data of PriorBoxOp, the layout is NCHW.


image(variable) --> image (Variable)

qingqing01

@chengduoZH Thank you!

qingqing01 · 2018-02-11T12:24:11Z

python/paddle/v2/fluid/layers/detection.py

+]
+
+
+def prior_boxes(inputs,


prior_boxes -> prior_box

qingqing01 · 2018-02-11T12:24:20Z

python/paddle/v2/fluid/layers/detection.py

+
+__all__ = [
+    'prior_box',
+    'prior_boxes',


remove prior_boxes

qingqing01 · 2018-02-11T12:27:39Z

python/paddle/v2/fluid/tests/object_detection/test_prior_boxes.py

+        main(use_cuda=False)
+
+    def test_cuda(self):
+        main(use_cuda=True)


Need to move test to https://github.com/PaddlePaddle/Paddle/blob/develop/python/paddle/v2/fluid/tests/test_detection.py

box and var shape can be checked without exe.run

… feature/add_prior_box_py

wanghaox

LGTM

… feature/add_prior_box_py

chengduoZH force-pushed the feature/add_prior_box_py branch 3 times, most recently from 34ccd60 to 540f93a Compare February 8, 2018 07:52

add Python interface of prior_boxes

dd6b59d

chengduoZH force-pushed the feature/add_prior_box_py branch 3 times, most recently from 542e3ba to 64151ed Compare February 8, 2018 11:35

refine prior_box

19749d5

chengduoZH force-pushed the feature/add_prior_box_py branch from 64151ed to 19749d5 Compare February 8, 2018 11:36

chengduoZH requested review from wanghaox, pkuyym and qingqing01 February 8, 2018 11:37

chengduoZH force-pushed the feature/add_prior_box_py branch 2 times, most recently from 80a9241 to 2d8ef00 Compare February 9, 2018 10:45

add doc for prior box

3cdb419

chengduoZH force-pushed the feature/add_prior_box_py branch 2 times, most recently from b6108b2 to 679e500 Compare February 9, 2018 11:59

delete conflict

5f15037

chengduoZH changed the title ~~[WIP]Add Python interface of prior_boxes~~ Add Python interface of prior_boxes Feb 9, 2018

chengduoZH force-pushed the feature/add_prior_box_py branch from 679e500 to 5f15037 Compare February 9, 2018 12:10

qingqing01 reviewed Feb 9, 2018

View reviewed changes

qingqing01 mentioned this pull request Feb 9, 2018

The TODO lists for MobileNet-SSD model. #7488

Closed

25 tasks

follow comments and code refine

4a8559c

chengduoZH force-pushed the feature/add_prior_box_py branch from b15f161 to 4a8559c Compare February 10, 2018 06:38

chengduoZH added 2 commits February 11, 2018 09:20

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

282dadb

… feature/add_prior_box_py

fix prior_op unit test

cf2ed17

chengduoZH force-pushed the feature/add_prior_box_py branch from 4bbe93c to cf2ed17 Compare February 11, 2018 03:25

qingqing01 reviewed Feb 11, 2018

View reviewed changes

pkuyym reviewed Feb 11, 2018

View reviewed changes

add unit test

74f7aff

chengduoZH force-pushed the feature/add_prior_box_py branch 4 times, most recently from fc0ad2a to 02a9bfc Compare February 11, 2018 09:23

pkuyym reviewed Feb 11, 2018

View reviewed changes

chengduoZH force-pushed the feature/add_prior_box_py branch 7 times, most recently from 229ea69 to 15e35fb Compare February 11, 2018 11:52

follow comments

d641d5a

chengduoZH force-pushed the feature/add_prior_box_py branch from 15e35fb to d641d5a Compare February 11, 2018 11:56

qingqing01 reviewed Feb 11, 2018

View reviewed changes

follow comments of qingqing

bbff442

chengduoZH force-pushed the feature/add_prior_box_py branch 4 times, most recently from 20f7fdf to c1082c9 Compare February 12, 2018 01:54

remove conflict

5ccab2d

chengduoZH force-pushed the feature/add_prior_box_py branch from c1082c9 to 5ccab2d Compare February 12, 2018 01:56

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

adc058a

… feature/add_prior_box_py

wanghaox reviewed Feb 12, 2018

View reviewed changes

chengduoZH force-pushed the feature/add_prior_box_py branch from d551be9 to 7a05263 Compare February 12, 2018 03:28

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

dff1bf3

… feature/add_prior_box_py

chengduoZH force-pushed the feature/add_prior_box_py branch from 7a05263 to dff1bf3 Compare February 12, 2018 04:04

qingqing01 approved these changes Feb 12, 2018

View reviewed changes

chengduoZH merged commit 7757a8a into PaddlePaddle:develop Feb 12, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Python interface of prior_boxes #8265

Add Python interface of prior_boxes #8265

chengduoZH commented Feb 8, 2018 •

edited

Loading

qingqing01 Feb 9, 2018

chengduoZH Feb 9, 2018

qingqing01 Feb 9, 2018

CLAassistant commented Feb 10, 2018 •

edited

Loading

qingqing01 Feb 11, 2018

chengduoZH Feb 11, 2018

qingqing01 Feb 11, 2018

chengduoZH Feb 11, 2018 •

edited

Loading

qingqing01 Feb 11, 2018

pkuyym Feb 9, 2018

chengduoZH Feb 11, 2018

pkuyym Feb 11, 2018

chengduoZH Feb 11, 2018

pkuyym Feb 11, 2018

chengduoZH Feb 11, 2018

pkuyym Feb 11, 2018

chengduoZH Feb 11, 2018

pkuyym Feb 11, 2018

chengduoZH Feb 11, 2018

qingqing01 left a comment

qingqing01 Feb 11, 2018

chengduoZH Feb 11, 2018

qingqing01 Feb 11, 2018

chengduoZH Feb 11, 2018

qingqing01 Feb 11, 2018

chengduoZH Feb 11, 2018

wanghaox left a comment

Add Python interface of prior_boxes #8265

Add Python interface of prior_boxes #8265

Conversation

chengduoZH commented Feb 8, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

CLAassistant commented Feb 10, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chengduoZH Feb 11, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

qingqing01 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wanghaox left a comment

Choose a reason for hiding this comment

chengduoZH commented Feb 8, 2018 •

edited

Loading

CLAassistant commented Feb 10, 2018 •

edited

Loading

chengduoZH Feb 11, 2018 •

edited

Loading