Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MultiBox API #8382

Merged
merged 6 commits into from
Feb 12, 2018
Merged

Add MultiBox API #8382

merged 6 commits into from
Feb 12, 2018

Conversation

chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Feb 11, 2018 •
edited
Loading

fix #8399

@CLAassistant
Copy link

CLAassistant commented Feb 11, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@chengduoZH chengduoZH force-pushed the feature/multiBoxHead branch 4 times, most recently from 9fe86bf to f8e5d58 Compare February 12, 2018 03:46
@chengduoZH chengduoZH changed the title [WIP] Add MultiBox API Add MultiBox API Feb 12, 2018
qingqing01
qingqing01 reviewed Feb 12, 2018
View reviewed changes
python/paddle/v2/fluid/nets.py Outdated
@@ -107,6 +108,38 @@ def __extend_list__(obj):
return pool_out


def img_conv_with_bn(input,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not wrap this API in Fluid.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

python/paddle/v2/fluid/layers/detection.py Outdated
from tensor import concat
from ops import reshape
from nn import transpose
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

import ops
import nn

下面调用：ops.reshape ops.transpose

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@chengduoZH chengduoZH force-pushed the feature/multiBoxHead branch 2 times, most recently from 031f88a to 2e4cbde Compare February 12, 2018 06:17
pkuyym
pkuyym reviewed Feb 12, 2018
View reviewed changes
python/paddle/v2/fluid/layers/detection.py Outdated
MultiBox Detector)<https://arxiv.org/abs/1512.02325>`_ .

Args:
inputs(list): The list of input Variables, the format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list|tuple

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

python/paddle/v2/fluid/layers/detection.py Outdated
Args:
inputs(list): The list of input Variables, the format
of all Variables is NCHW.
num_classes(int): The number of calss.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calss --> classes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

python/paddle/v2/fluid/layers/detection.py Outdated
inputs(list): The list of input Variables, the format
of all Variables is NCHW.
num_classes(int): The number of calss.
min_sizes(list, optional, default=None): The length of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list --> list|tuple

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

python/paddle/v2/fluid/layers/detection.py Outdated
inputs(list): The list of input Variables, the format
of all Variables is NCHW.
num_classes(int): The number of calss.
min_sizes(list, optional, default=None): The length of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

length --> number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

python/paddle/v2/fluid/layers/detection.py Outdated
of all Variables is NCHW.
num_classes(int): The number of calss.
min_sizes(list, optional, default=None): The length of
min_size is used to compute the the number of prior box.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

python/paddle/v2/fluid/layers/detection.py Outdated
to min_ratio and max_ratio.
max_sizes(list, optional, default=None): The length of max_size
is used to compute the the number of prior box.
min_ratio(int): If the min_sizes is None, min_ratio and min_ratio
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min_ratio --> max_ratio ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

python/paddle/v2/fluid/layers/detection.py Outdated
and max_size according to min_ratio and max_ratio.
flip(bool, optional, default=False): Whether to flip
aspect ratios.
name(str, optional, None): Name of the prior box layer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(str|None)

python/paddle/v2/fluid/layers/detection.py Outdated
compute the number of prior box.
base_size(int): the base_size is used to get min_size
and max_size according to min_ratio and max_ratio.
flip(bool, optional, default=False): Whether to flip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool|None

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

python/paddle/v2/fluid/layers/detection.py Outdated
act=conv_act,
use_cudnn=use_cudnn)

if conv_with_batchnorm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check here.

@chengduoZH chengduoZH force-pushed the feature/multiBoxHead branch 2 times, most recently from 7f99f6a to f1ba425 Compare February 12, 2018 08:30
@chengduoZH chengduoZH force-pushed the feature/multiBoxHead branch 3 times, most recently from 054fcdc to 58ec4ea Compare February 12, 2018 08:51
@chengduoZH chengduoZH merged commit 86657db into PaddlePaddle:develop Feb 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkuyym pkuyym pkuyym left review comments

@qingqing01 qingqing01 qingqing01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrap Python API for MultiBox
4 participants
@chengduoZH @CLAassistant @pkuyym @qingqing01