Get rid of the dependency of Go compiler when WITH_GOLANG is OFF. #8610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Feb 28, 2018
| @@ -58,7 +58,7 @@ Users can specify the following Docker build arguments with either "ON" or "OFF" | |||
| | `WITH_AVX` | OFF | Set to "ON" to enable AVX support. | | |||
| | `WITH_TESTING` | OFF | Build unit tests binaries. | | |||
| | `WITH_MKL` | ON | Build with [Intel® MKL](https://software.intel.com/en-us/mkl) and [Intel® MKL-DNN](https://github.com/01org/mkl-dnn) support. | | |||
| | `WITH_GOLANG` | ON | Build fault-tolerant parameter server written in go. | | |||
| | `WITH_GOLANG` | OFF | Build fault-tolerant parameter server written in go. | | |||
There was a problem hiding this comment.
May also change paddle/scripts/docker/build.sh to make this default OFF
There was a problem hiding this comment.
Paddle/paddle/scripts/docker/build.sh
Line 68 in a67ceba
If changing the above value to OFF, then CI cannot test the go codes? Maybe I should change the value in README.md back to ON?
There was a problem hiding this comment.
We can configure CI to enable golang explicitly to run the tests, the defaults can be still OFF.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CMake, project is used to set a name, version, and enable languages for the entire project.
We can call enable_language to enable the
Golanguage optionally.It can fix problems in #8555 #5427 #3741 etc.