Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nccl version in manylinux develop Docker image #8708

Merged
merged 1 commit into from
Mar 8, 2018
Merged

Fix nccl version in manylinux develop Docker image #8708

merged 1 commit into from
Mar 8, 2018

Conversation

Yancey1989
Copy link
Contributor

Fixed #8635

@Yancey1989 Yancey1989 changed the title Fix nccl version in manylinux Fix nccl version in manylinux develop Docker image Mar 2, 2018
typhoonzero
typhoonzero approved these changes Mar 2, 2018
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@typhoonzero
Copy link
Contributor

@Yancey1989 we also need to push this update to dockerhub?

@Yancey1989
Copy link
Contributor Author

@typhoonzero Sure, will do that after merged this PR.

@Yancey1989 Yancey1989 merged commit 281f5fd into PaddlePaddle:develop Mar 8, 2018
@Yancey1989 Yancey1989 deleted the fix_manylinux_nccl_version branch March 8, 2018 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typhoonzero typhoonzero typhoonzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yancey1989 @typhoonzero