Improve the timeline profiler #8775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panyx0718
requested review from
qingqing01,
chengduoZH and
jacquesqiao
and removed request for
chengduoZH
smaller binary proto avoid untrackable kernel
jacquesqiao
reviewed
Mar 6, 2018
| } | ||
|
|
||
| void AddMemRecords(const std::string &name, uint64_t start_ns, | ||
| uint64_t end_ns, uint32_t device_id, uint32_t stream_id, | ||
| uint32_t correlation_id, uint64_t bytes) { | ||
| // 0 means timestamp information could not be collected for the kernel. | ||
| if (start_ns == 0 || end_ns == 0) { |
jacquesqiao
reviewed
Mar 8, 2018
| mem_records_.push_back(MemRecord{name, start_ns, end_ns, device_id, | ||
| stream_id, correlation_id, bytes}); | ||
| } | ||
|
|
||
| void AddKernelRecords(uint64_t start, uint64_t end, uint32_t device_id, | ||
| uint32_t stream_id, uint32_t correlation_id) { | ||
| // 0 means timestamp information could not be collected for the kernel. | ||
| if (start == 0 || end == 0) { | ||
| LOG(WARNING) << correlation_id << " cannot be traced"; |
There was a problem hiding this comment.
please use
VLOG(level) << ...;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use binary instead of text format
Avoid kernels that cannot be traced.