Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign channel implementation for Select Op #8814

Merged
merged 3 commits into from
Mar 6, 2018
Merged

Redesign channel implementation for Select Op #8814

merged 3 commits into from
Mar 6, 2018

Conversation

abhinavarora
Copy link
Contributor

@abhinavarora abhinavarora commented Mar 6, 2018 •
edited
Loading

Fixes #8812

Like Go, we will also have one single implementation for both buffered and unbuffered channels.
References:

  1. Channel Send - https://github.com/golang/go/blob/master/src/runtime/chan.go#L140
  2. Channel Receive - https://github.com/golang/go/blob/master/src/runtime/chan.go#L417
  3. Channel Close - https://github.com/golang/go/blob/master/src/runtime/chan.go#L327

@abhinavarora abhinavarora self-assigned this Mar 6, 2018
cs2be
cs2be previously approved these changes Mar 6, 2018
View reviewed changes
Copy link
Contributor

@cs2be cs2be left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

paddle/fluid/framework/channel_impl.h Outdated
if (closed_ && buf_.empty()) {
lock.unlock();
return recv_return(false);
// return false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove this

@abhinavarora abhinavarora merged commit 78c884d into PaddlePaddle:develop Mar 6, 2018
@abhinavarora abhinavarora deleted the redesign_channel branch March 6, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cs2be cs2be cs2be approved these changes

@varunarora varunarora Awaiting requested review from varunarora

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

@chengduoZH chengduoZH Awaiting requested review from chengduoZH

Assignees

@abhinavarora abhinavarora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhinavarora @cs2be