Performance/zero copy variable seriralization #8839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… polish_grpc_server
typhoonzero
changed the title
gongweibao
requested changes
Mar 7, 2018
| void* payload; | ||
| size_t payload_size; | ||
| ProtoEncodeHelper e((char*)buf, 1024); | ||
| e.WriteString(1, name); |
There was a problem hiding this comment.
Use kvarnameFieldNumber which defined in xxx.pb.h instead of number.
And the follows are the same problem.
|
Thanks for the quick implementation! It's awesome! |
gongweibao
reviewed
Mar 9, 2018
| #ifdef PADDLE_WITH_CUDA | ||
| platform::CPUPlace cpu; | ||
| auto& gpu_dev_ctx = static_cast<const platform::CUDADeviceContext&>(ctx); | ||
| memory::Copy(boost::get<platform::CUDAPlace>(tensor->place()), |
There was a problem hiding this comment.
This can be optimized to copy all and wait once.I will optimize it in another PR.
typhoonzero
changed the title
This was referenced Mar 9, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8838
Related: #8638