Use async instead of defered for threadpool threads. #8901
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have much background. Feel free to let me know "deferred" is the expected
behavior.
Reason for the change:
defered means you need to call get/wait first, then
the thread starts to run.
async means the thread starts ASAP, wait/get are only
used to get the result.
The code comment says:
To wait for the completion of the task, call std::future::wait()
Hence, user would expect wait() is not a method to start the thread.
It seems more reasonable to start running when the thread is available
instead of waiting for a wait/get call.