Enable P2P memory copy #9190
Merged
Enable P2P memory copy #9190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengduoZH
reviewed
Mar 19, 2018
paddle/fluid/framework/init.cc
Outdated
| PADDLE_ENFORCE(cudaDeviceCanAccessPeer(&can_acess, i, j), | ||
| "Failed to test P2P access."); | ||
| if (can_acess != 1) { | ||
| VLOG(1) << "Cannot enable P2P access from " << i << " to " << j; |
There was a problem hiding this comment.
It may be better to use LOG(WARNING).
There was a problem hiding this comment.
Agreed. VLOG for debugging only. #5181
LOG(WARNING) is better here.
dzhwinter
reviewed
Mar 19, 2018
paddle/fluid/framework/init.cc
Outdated
| VLOG(1) << "Cannot enable P2P access from " << i << " to " << j; | ||
| } else { | ||
| cudaSetDevice(i); | ||
| cudaDeviceEnablePeerAccess(j, 0); |
There was a problem hiding this comment.
Is P2P Access need any specific hardware? I vaguely remember that it needs the slim-connect(or something)?
There was a problem hiding this comment.
It needs to be tesla. So gforce titan x doesn't support it
paddle/fluid/framework/init.cc
Outdated
| PADDLE_ENFORCE(cudaDeviceCanAccessPeer(&can_acess, i, j), | ||
| "Failed to test P2P access."); | ||
| if (can_acess != 1) { | ||
| VLOG(1) << "Cannot enable P2P access from " << i << " to " << j; |
There was a problem hiding this comment.
Agreed. VLOG for debugging only. #5181
LOG(WARNING) is better here.
On k40 with 4 devices, time reduces from ~4.0 to ~3.8+, should be more obvious on better hardware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On k40 with 4 devices, time reduces from ~4.0 to ~3.8+, should be
more obvious on better hardware