Sgd support update selected rows #9597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sgd-support-update-selected-rows
15 tasks
chengduoZH
reviewed
Apr 4, 2018
paddle/fluid/operators/sgd_op.cc
Outdated
| ctx.device_context()); | ||
| } else { | ||
| PADDLE_THROW("Param should be LoDTensor or SelectedRows"); | ||
| } |
There was a problem hiding this comment.
line46-58 is similar to line21-35 of lookup_tabel_op, so I think we should add a new API, like GetPODTypeFromVar, do you think so?
| "when param " | ||
| "is SelectedRows, gradient should also be SelectedRows"); | ||
| const auto ¶m = param_var->Get<framework::SelectedRows>(); | ||
| auto *param_out = ctx.Output<framework::SelectedRows>("ParamOut"); |
There was a problem hiding this comment.
Can param_out and param be different?
There was a problem hiding this comment.
Currently, they need to share the same memory, but we should use different vars to represent them for:
- Input is const, the output is mutable.
- In the future, they can be different.
There was a problem hiding this comment.
Now that, it should have a check under line89, like: PADDLE_ENFORCE_EQ(param, param_out);. And adding TODO to describe this.
There was a problem hiding this comment.
I think this enforce is not needed.
… sgd-support-update-selected-rows
luotao1
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task list: #9211