Add Top-k Python API. #9973
Merged
Add Top-k Python API. #9973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Apr 17, 2018
| @@ -20,6 +20,7 @@ | |||
| from ..initializer import Normal, Constant | |||
| from ..framework import Variable | |||
| from ..param_attr import ParamAttr | |||
| import nn | |||
There was a problem hiding this comment.
Maybe we can delete this file and put accuracy and auc to evaluator.
Currently seems "evaluator" is the python wrapping using operators, and framework/metrics.py is a pure python implementation.
There was a problem hiding this comment.
Now we have:
It seems the fluid/evaluator.py will be removed and use fluid/metrics.py instead. But I'm not sure what is the final conclusion. So these cleanups maybe can be done in the future.
There was a problem hiding this comment.
I see. We must change all the demo and models code if this change happens. This PR LGTM then.
typhoonzero
previously approved these changes
Apr 17, 2018
| @@ -20,6 +20,7 @@ | |||
| from ..initializer import Normal, Constant | |||
| from ..framework import Variable | |||
| from ..param_attr import ParamAttr | |||
| import nn | |||
There was a problem hiding this comment.
I see. We must change all the demo and models code if this change happens. This PR LGTM then.
chengduoZH
approved these changes
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9974