Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Done]Fault tolerant job #212

Merged
merged 7 commits into from
Jul 20, 2017
Merged

Conversation

typhoonzero
Copy link
Collaborator

@typhoonzero typhoonzero commented Jul 13, 2017

Fix #213

@typhoonzero typhoonzero changed the title [WIP]Fault tolerant job [Done]Fault tolerant job Jul 19, 2017
@@ -107,6 +112,7 @@ func NewSubmitter(cmd *SubmitCmd) *Submitter {
func (s *Submitter) Submit(jobPackage string, jobName string) error {
// if jobPackage is not a local dir, skip uploading package.
_, pkgerr := os.Stat(jobPackage)
fmt.Println("1")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about use some useful comment instead of numbers.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's test message, will remove.

@@ -101,11 +113,28 @@ def _get_pserver_container_ports(self):
port += 1
return ports

def _get_master_container_ports(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the master port will export the etcd port and master port?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@typhoonzero typhoonzero merged commit 009314e into PaddlePaddle:develop Jul 20, 2017
Yancey1989 added a commit that referenced this pull request Jul 23, 2017
* tutorial and usage update

* first add

* rm not need

* fix bugs

* add logging

* add docker file

* fix by yancey's comment

* update

* save parameter

* fix yaml

* fix bugs

* fix bugs

* fix convert bug

* fix by wuyi's comment

* add readme

* rm logging.confg

* modify README.md

* modify README.md

* add start command

* update

* update by comments

* upload files with recursion

* prettify output

* remove replica set name

* recursion to loop

* dlnel index page (#194)

* switch to dlnel index page

* mount template files

* delete unused comments

* add port env

* update tutorial (#202)

* update tutorial

* update

* remove unused line

* update

* update

* update

* test format

* modify travis.yaml

* fix

* fix

* fix sudo

* add travis

* add glide

* add gimme

* fix style

* fix style

* add files

* modify sh

* fix by wuyi's comments

* fix pre-commit bugs

* Format quota print (#205)

* forat quota print

* update

* add sleep for pserver get ready (#216)

* Update readme (#214)

* update readme

* update

* Enable ingress notebook access (#219)

* enable ingress notebook access

* update notebook resource

* test ok

* fix

* fix

* fix login url (#229)

* Fix invalid job path (#227)

* fix invalid job path

* update doc

* check job name in clint (#231)

* [Done]Fault tolerant job (#212)

* fault tolerant job

* ft job

* update

* tested job submit with ft job

* update
Yancey1989 added a commit that referenced this pull request Jul 23, 2017
* tutorial and usage update

* first add

* rm not need

* fix bugs

* add logging

* add docker file

* fix by yancey's comment

* update

* save parameter

* fix yaml

* fix bugs

* fix bugs

* fix convert bug

* fix by wuyi's comment

* add readme

* rm logging.confg

* modify README.md

* modify README.md

* add start command

* update

* update by comments

* upload files with recursion

* prettify output

* remove replica set name

* recursion to loop

* dlnel index page (#194)

* switch to dlnel index page

* mount template files

* delete unused comments

* add port env

* update tutorial (#202)

* update tutorial

* update

* remove unused line

* update

* update

* update

* test format

* modify travis.yaml

* fix

* fix

* fix sudo

* add travis

* add glide

* add gimme

* fix style

* fix style

* add files

* modify sh

* fix by wuyi's comments

* fix pre-commit bugs

* Format quota print (#205)

* forat quota print

* update

* add sleep for pserver get ready (#216)

* Update readme (#214)

* update readme

* update

* Enable ingress notebook access (#219)

* enable ingress notebook access

* update notebook resource

* test ok

* fix

* fix

* fix login url (#229)

* Fix invalid job path (#227)

* fix invalid job path

* update doc

* check job name in clint (#231)

* [Done]Fault tolerant job (#212)

* fault tolerant job

* ft job

* update

* tested job submit with ft job

* update

* fix ci
@typhoonzero typhoonzero deleted the ftjob branch November 2, 2017 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants