fix compatibility for ppnimilm, skep, unifiedtransformer, gpt2 #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoshengCS
reviewed
May 5, 2022
| return self.convert_tokens_to_ids(tokens) | ||
| else: | ||
| return self.convert_tokens_to_ids(text) | ||
| return self.convert_tokens_to_ids(text) |
|
PR描述里说明下目前会造成哪些影响吧 |
|
也再确认下code style，看着这个CI挂了 |
|
另外 @yingyibiao 也关注下，主要是 tokenzier 这里留的一些 TODO和NOTE |
guoshengCS
approved these changes
May 7, 2022
| @@ -127,6 +127,7 @@ def __init__( | |||
| **kwargs # The token of newline. | |||
| ): | |||
| self._model_file = model_file | |||
| self.eol_token = eol_token | |||
There was a problem hiding this comment.
这里加上TODO说明下吧，说明GPT tokenzier我们的实现有些特殊，有个eol_token
This was referenced Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Description
fix compatibility for ppnimilm, skep, unifiedtransformer, gpt2
ppnimilm：使用升级后tokenizer存储和读取时会报错
skep：序列标注任务训练和预测报错
unifiedtransformer：使用padding后训练和预测会报错
gpt2：调用tokenizer.eol_token会报错