Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug: add parameter encoding='utf-8' while opening vocab.bpe #2209

Merged
merged 1 commit into from
May 18, 2022
Merged

fix bug: add parameter encoding='utf-8' while opening vocab.bpe #2209

merged 1 commit into from
May 18, 2022

Conversation

lugimzzz
Copy link
Contributor

PR types

Bug fixes

PR changes

APIs

Description

Though python3 set default IO encoding to utf-8, some windows users still have other default IO encoding setting (e.g. cp1252), which causes problem when open 'vocab.bpe' file. It's better to call open() with an explicit parameter, encoding='utf-8'.

@ZeyuChen ZeyuChen merged commit e7bb926 into PaddlePaddle:develop May 18, 2022
@lugimzzz lugimzzz deleted the fix_io_bug branch July 4, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants