Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tokenizer isfile checking code #2424

Merged
merged 2 commits into from
Jun 7, 2022
Merged

fix tokenizer isfile checking code #2424

merged 2 commits into from
Jun 7, 2022

Conversation

wj-Mcat
Copy link
Contributor

@wj-Mcat wj-Mcat commented Jun 7, 2022

PR types

Bug fixes

PR changes

Models

Description

there is a stupid error in my pr, so I create an another pr to fix it.

            elif not os.path.isfile(init_kwargs[args_name],
                                    '') and os.path.isfile(file_path):

changed to:

            elif not os.path.isfile(init_kwargs[args_name] or 
                                    '') and os.path.isfile(file_path):

@guoshengCS guoshengCS mentioned this pull request Jun 7, 2022
Closed
@guoshengCS
Copy link
Contributor

注意使用 pre-commit ，看CodeStyle的CI没过

@wj-Mcat
Copy link
Contributor Author

wj-Mcat commented Jun 7, 2022

@guoshengCS 嗯嗯，我正在安装调整。

guoshengCS
guoshengCS approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@guoshengCS guoshengCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guoshengCS
Copy link
Contributor

Resolve #2413

@guoshengCS guoshengCS merged commit 3ec1d35 into PaddlePaddle:develop Jun 7, 2022
@wj-Mcat wj-Mcat mentioned this pull request Jun 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshengCS guoshengCS guoshengCS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wj-Mcat @guoshengCS