Fix special token settings in PretrainiedTokenizer #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto fix-spe-token
ZHUI
approved these changes
Jun 24, 2022
| @@ -559,10 +559,24 @@ def _wrap_init(self, original_init, *args, **kwargs): | |||
| self._decode_use_source_tokenizer = False | |||
|
|
|||
| def _build_special_tokens_map_extended(self, **kwargs): | |||
| if getattr(self, "_has_built_special_tokens", None): | |||
| return | |||
| SpecialTokensMixin.__init__(self, **kwargs) | |||
There was a problem hiding this comment.
看得不是很明白，这里是去掉了 SpecialTokensMixin 的使用了吗？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Description
Fix special token settings in PretrainiedTokenizer.
Resolve #2630
Additionally, by using
_post_initto replace_wrap_initand add_pre_init, we can addConfigurationand parseConfigurationin_pre_initas arguments ofPretrainedModel.__init__to create models later.