Fix faiss index batch_size bug on python3.7 and update es config for … #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianxin1860
reviewed
Aug 5, 2022
| @@ -15,6 +15,7 @@ | |||
| parser.add_argument("--max_seq_len_query", default=64, type=int, help="The maximum total length of query after tokenization.") | |||
| parser.add_argument("--max_seq_len_passage", default=256, type=int, help="The maximum total length of passage after tokenization.") | |||
| parser.add_argument("--retriever_batch_size", default=16, type=int, help="The batch size of retriever to extract passage embedding for building ANN index.") | |||
| parser.add_argument("--update_batch_size", default=100, type=int, help="The batch size of document_store to update passage embedding for building ANN index.") | |||
There was a problem hiding this comment.
update_batch_size 和 retriever_batch_size 之间的关系是什么？
There was a problem hiding this comment.
这是faiss的update_embeddings的参数,它给的解释是：
:param batch_size: When working with large number of documents, batching can help reduce memory footprint.
retriever_batch_size是DensePassageRetriever的参数，它给的解释是
:param batch_size: Number of questions or passages to encode at once. In case of multiple gpus, this will be the total batch size.
https://github.com/PaddlePaddle/PaddleNLP/blob/develop/applications/experimental/pipelines/pipelines/nodes/retriever/dense.py
There was a problem hiding this comment.
如线下讨论，不适合暴露 update_batch_size 参数，直接修改 pipeline 默认值即可。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pipelines
PR types
PR changes
Description