Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix]enable fix-lock in configuration downloading #4274

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

wj-Mcat
Copy link
Contributor

@wj-Mcat wj-Mcat commented Dec 29, 2022

PR types

Bug fixes

PR changes

Models

Description

虽然config.json 文件很小,可是在多卡多进程下载的时候还是有可能出现问题,所以此时也需要将file-lock 的 feature 引入到Configuration 模块当中。

@paddle-bot
Copy link

paddle-bot bot commented Dec 29, 2022

Thanks for your contribution!

@wj-Mcat wj-Mcat marked this pull request as ready for review December 29, 2022 01:53
@wj-Mcat wj-Mcat requested a review from sijunhe December 29, 2022 01:53
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Merging #4274 (761f0b4) into develop (2c465df) will increase coverage by 1.26%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #4274      +/-   ##
===========================================
+ Coverage    35.08%   36.34%   +1.26%     
===========================================
  Files          408      419      +11     
  Lines        57029    59165    +2136     
===========================================
+ Hits         20008    21506    +1498     
- Misses       37021    37659     +638     
Impacted Files Coverage Δ
paddlenlp/transformers/configuration_utils.py 67.93% <0.00%> (+0.07%) ⬆️
paddlenlp/trainer/trainer_utils.py 29.58% <0.00%> (-5.24%) ⬇️
paddlenlp/taskflow/text_classification.py 94.25% <0.00%> (-1.15%) ⬇️
paddlenlp/experimental/ernie_model.py 32.43% <0.00%> (-0.91%) ⬇️
paddlenlp/metrics/span.py 22.22% <0.00%> (-0.51%) ⬇️
paddlenlp/transformers/roberta/modeling.py 89.85% <0.00%> (-0.37%) ⬇️
paddlenlp/transformers/unimo/modeling.py 82.58% <0.00%> (-0.29%) ⬇️
paddlenlp/transformers/feature_extraction_utils.py 27.02% <0.00%> (-0.19%) ⬇️
paddlenlp/transformers/mbart/modeling.py 81.76% <0.00%> (-0.18%) ⬇️
paddlenlp/transformers/bart/modeling.py 85.30% <0.00%> (-0.14%) ⬇️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@sijunhe sijunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@sijunhe sijunhe merged commit def43c5 into PaddlePaddle:develop Dec 29, 2022
@sijunhe sijunhe mentioned this pull request Dec 29, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants