Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLIP, ErnieViL, ChineseCLIP Remove from_pretrained_v2 #4797

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

JunnYu
Copy link
Member

@JunnYu JunnYu commented Feb 14, 2023

PR types

Function optimization

PR changes

APIs

Description

  • 由于这里增加了判断,因此我们无需重写这个代码。
    if not os.path.exists(os.path.join(cache_dir, CONFIG_NAME)):
    config.save_pretrained(cache_dir)
  • 现有的CLIP, ErnieViL, ChineseCLIP的模型的config均是最新的config.json。

@JunnYu JunnYu requested a review from sijunhe February 14, 2023 12:18
@paddle-bot
Copy link

paddle-bot bot commented Feb 14, 2023

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #4797 (acb376d) into develop (2992a81) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4797      +/-   ##
===========================================
- Coverage    44.14%   44.08%   -0.07%     
===========================================
  Files          443      443              
  Lines        63440    63334     -106     
===========================================
- Hits         28008    27920      -88     
+ Misses       35432    35414      -18     
Impacted Files Coverage Δ
paddlenlp/transformers/chineseclip/modeling.py 85.48% <ø> (-0.03%) ⬇️
paddlenlp/transformers/clip/modeling.py 58.91% <ø> (-1.78%) ⬇️
paddlenlp/transformers/ernie_vil/modeling.py 77.63% <ø> (-1.96%) ⬇️
paddlenlp/transformers/t5/modeling.py 85.11% <0.00%> (+0.29%) ⬆️
paddlenlp/utils/downloader.py 66.07% <0.00%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@sijunhe sijunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JunnYu JunnYu merged commit 47fce78 into PaddlePaddle:develop Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants