Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npu nn.Pad2D() #5167

Merged
merged 1 commit into from
Mar 9, 2023
Merged

fix npu nn.Pad2D() #5167

merged 1 commit into from
Mar 9, 2023

Conversation

zws-2019
Copy link
Contributor

@zws-2019 zws-2019 commented Mar 9, 2023

PR types

Bug fixes

PR changes

Others

Description

fix npu nn.Pad2D()

@paddle-bot
Copy link

paddle-bot bot commented Mar 9, 2023

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2023

CLA assistant check
All committers have signed the CLA.

@parap1uie-s
Copy link
Contributor

parap1uie-s commented Mar 9, 2023

在NPU环境使用ppnlp时遇到的算子兼容性问题,采用修改算子参数的方式确保模型可以在NPU设备运行

@zws-2019
Copy link
Contributor Author

zws-2019 commented Mar 9, 2023

在NPU环境使用ppnlp时遇到的算子兼容性问题,采用修改算子参数的方式确保模型可以在NPU设备运行

请问这个Test / Test (pull_request) 失败,如何处理?

Copy link
Collaborator

@sijunhe sijunhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sijunhe
Copy link
Collaborator

sijunhe commented Mar 9, 2023

在NPU环境使用ppnlp时遇到的算子兼容性问题,采用修改算子参数的方式确保模型可以在NPU设备运行

请问这个Test / Test (pull_request) 失败,如何处理?

我们的ci的小问题,不是PR的问题,晚点就merge

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #5167 (3579d3d) into develop (c7395fb) will increase coverage by 0.35%.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop    #5167      +/-   ##
===========================================
+ Coverage    50.93%   51.29%   +0.35%     
===========================================
  Files          461      461              
  Lines        65731    65735       +4     
===========================================
+ Hits         33481    33718     +237     
+ Misses       32250    32017     -233     
Impacted Files Coverage Δ
paddlenlp/transformers/generation_utils.py 81.31% <66.66%> (-0.20%) ⬇️
paddlenlp/metrics/chunk.py 46.47% <0.00%> (+26.76%) ⬆️
paddlenlp/metrics/rouge.py 59.09% <0.00%> (+35.60%) ⬆️
paddlenlp/metrics/distinct.py 71.87% <0.00%> (+40.62%) ⬆️
paddlenlp/metrics/glue.py 86.93% <0.00%> (+41.89%) ⬆️
paddlenlp/metrics/bleu.py 66.66% <0.00%> (+48.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sijunhe sijunhe merged commit b8d23a1 into PaddlePaddle:develop Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants