Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fixes] fix generation cache bug #5535

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

wj-Mcat
Copy link
Contributor

@wj-Mcat wj-Mcat commented Apr 4, 2023

PR types

Bug fixes

PR changes

Models

Description

解决生成式 API cache 被清空的bug

@paddle-bot
Copy link

paddle-bot bot commented Apr 4, 2023

Thanks for your contribution!

@wj-Mcat wj-Mcat requested a review from gongel April 4, 2023 10:09
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #5535 (ee23a21) into develop (17d0664) will increase coverage by 0.07%.
The diff coverage is 48.00%.

@@             Coverage Diff             @@
##           develop    #5535      +/-   ##
===========================================
+ Coverage    59.23%   59.31%   +0.07%     
===========================================
  Files          478      481       +3     
  Lines        67558    68097     +539     
===========================================
+ Hits         40021    40392     +371     
- Misses       27537    27705     +168     
Impacted Files Coverage Δ
paddlenlp/transformers/generation_utils.py 71.25% <48.00%> (-3.04%) ⬇️

... and 24 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@wj-Mcat wj-Mcat marked this pull request as ready for review April 4, 2023 11:20
wawltor
wawltor previously approved these changes Apr 6, 2023
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

重点检查一下 OPT、GPT、GLM、Bloom是否可以适配相应的修改

Copy link
Member

@gongel gongel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beam search那儿也要加下

@wj-Mcat
Copy link
Contributor Author

wj-Mcat commented Apr 6, 2023

@gongel 我这边看了下,beam_searchgroup_beam_search 都调整了。

@gongel
Copy link
Member

gongel commented Apr 6, 2023

LGTM

重点检查一下 OPT、GPT、GLM、Bloom是否可以适配相应的修改

这个问题是 #5025 引入的,京京可以看下修复后cache是否被清空。

@wj-Mcat wj-Mcat merged commit 8737f68 into PaddlePaddle:develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants