Use our own Linear layer for easier tie_weights; Fix resize_token_embeddings API #5623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
sijunhe
changed the title
sijunhe
changed the title
JunnYu
reviewed
Apr 12, 2023
JunnYu
reviewed
Apr 12, 2023
sijunhe
commented
Apr 12, 2023
| @@ -94,12 +94,14 @@ def __init__( | |||
| layer_norm_epsilon: float = 1e-05, | |||
| initializer_range: float = 0.02, | |||
| n_inner: int = None, | |||
| tie_word_embeddings: bool = False, | |||
There was a problem hiding this comment.
一般模型都是默认tie_weights为True, 而codegen的tie_word_embeddings是false的，所以这里特定指定一下，要不然resize_word_embeddings会出问题
Codecov Report
@@ Coverage Diff @@
## develop #5623 +/- ##
===========================================
- Coverage 59.47% 59.45% -0.03%
===========================================
Files 482 483 +1
Lines 68105 68187 +82
===========================================
+ Hits 40506 40541 +35
- Misses 27599 27646 +47
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JunnYu
reviewed
Apr 13, 2023
gongel
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
PR changes
Description