Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix python include path #6347

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

zhiqiu
Copy link
Collaborator

@zhiqiu zhiqiu commented Jul 10, 2023

PR types

Bug fixes

PR changes

Others

Description

In some case, python -m pybind11 --includes returns /usr/local/include/python3.x/, but the real header file is in /usr/include/python3.x/. So, add python-config --includes.
Ref: https://stackoverflow.com/questions/72502292/fatal-error-python-h-no-such-file-or-directory-when-compiling-pybind11-example

@paddle-bot
Copy link

paddle-bot bot commented Jul 10, 2023

Thanks for your contribution!

@zhiqiu zhiqiu force-pushed the dev/fix_python_include branch from 7176d81 to b44f542 Compare July 10, 2023 12:10
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #6347 (b44f542) into develop (1d74603) will decrease coverage by 0.29%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6347      +/-   ##
===========================================
- Coverage    63.16%   62.88%   -0.29%     
===========================================
  Files          505      523      +18     
  Lines        70949    75903    +4954     
===========================================
+ Hits         44813    47729    +2916     
- Misses       26136    28174    +2038     

see 105 files with indirect coverage changes

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit c86cb84 into PaddlePaddle:develop Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants