paddle support stride, fix dy2st #6539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
ZeyuChen
requested changes
Aug 1, 2023
ZeyuChen
reviewed
Aug 1, 2023
ZHUI
reviewed
Aug 1, 2023
| @@ -1351,8 +1351,9 @@ def forward( | |||
|
|
|||
| option_logits = paddle.matmul(q.unsqueeze(1), k, transpose_y=True).squeeze(1) | |||
| option_logits = option_logits / self.predict_size**0.5 | |||
| for index, logit in enumerate(option_logits): | |||
| option_logits[index] -= (1 - (omask_positions[index] > 0).astype("float32")) * 1e12 | |||
| with paddle.fluid.framework._stride_in_no_check_dy2st_diff(): | |||
There was a problem hiding this comment.
需要保证旧版本的paddle正常运行，如 paddle 2.4.0
done, thx! |
done, thx! |
…nto support_stride_dy2st
ZHUI
approved these changes
Aug 2, 2023
|
|
||
| if hasattr(paddle.framework, "_no_check_dy2st_diff"): |
…nto support_stride_dy2st
Codecov Report
@@ Coverage Diff @@
## develop #6539 +/- ##
===========================================
- Coverage 62.94% 62.93% -0.01%
===========================================
Files 531 531
Lines 77721 77725 +4
===========================================
- Hits 48918 48917 -1
- Misses 28803 28808 +5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Paddle支持stride后，需要检查动转静不一致的情况。但检查难度大，简单的检查会有误报，但这种方式获得评审会的同意。通过with可以避免误报。