llama beam search fix #6882
Merged
llama beam search fix #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
sijunhe
previously approved these changes
Aug 31, 2023
Codecov Report
@@ Coverage Diff @@
## develop #6882 +/- ##
===========================================
- Coverage 59.93% 59.93% -0.01%
===========================================
Files 547 547
Lines 80996 81003 +7
===========================================
- Hits 48548 48547 -1
- Misses 32448 32456 +8
|
wj-Mcat
requested changes
Aug 31, 2023
| @@ -220,6 +221,12 @@ def test_model_attention_mask(self): | |||
| config_and_inputs = self.model_tester.prepare_config_and_inputs() | |||
| self.model_tester.create_and_check_model_attention_mask(*config_and_inputs) | |||
|
|
|||
| def test_beam_search_generate(self): | |||
There was a problem hiding this comment.
你这里写一下 TODO 吧，说明一下当前问题，后续需要修复。
sijunhe
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
PR changes
Description
修正llama beam search 错误