pretrainedModel add gconfig #6915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov Report
@@ Coverage Diff @@
## develop #6915 +/- ##
===========================================
- Coverage 59.92% 59.87% -0.06%
===========================================
Files 547 552 +5
Lines 81009 81452 +443
===========================================
+ Hits 48546 48770 +224
- Misses 32463 32682 +219
|
sijunhe
reviewed
Sep 5, 2023
llm/predictor.py
Outdated
| @@ -41,6 +41,7 @@ | |||
| PretrainedModel, | |||
| PretrainedTokenizer, | |||
| ) | |||
| from paddlenlp.transformers.generation_utils import GenerationConfig | |||
There was a problem hiding this comment.
尽量从paddlenlp.generation 路径import, 后续paddlenlp.transformers.generation_utils 逐渐废弃
Comment on lines
15
to
19
| from paddlenlp.generation.configuration_utils import * # noqa: F401, F403 | ||
| from paddlenlp.generation.logits_process import * # noqa: F401, F403 | ||
| from paddlenlp.generation.stopping_criteria import * # noqa: F401, F403 | ||
| from paddlenlp.generation.streamers import * # noqa: F401, F403 | ||
| from paddlenlp.generation.utils import * # noqa: F401, F403 |
There was a problem hiding this comment.
可不可以直接废弃调transformers/generation_utils? 后续都从transformers/generation import?
sijunhe
reviewed
Sep 5, 2023
llm/utils.py
Outdated
| @@ -26,6 +26,7 @@ | |||
| from sklearn.metrics import accuracy_score | |||
|
|
|||
| from paddlenlp.datasets import InTokensIterableDataset | |||
| from paddlenlp.generation import GenerationConfig | |||
llm/utils.py
Outdated
Comment on lines
204
to
213
| generation_config=GenerationConfig( | ||
| max_new_token=self.data_args.tgt_length, | ||
| decode_strategy="sampling", | ||
| top_k=self.gen_args.top_k, | ||
| top_p=self.gen_args.top_p, | ||
| bos_token_id=self.tokenizer.bos_token_id, | ||
| eos_token_id=self.tokenizer.eos_token_id, | ||
| pad_token_id=self.tokenizer.pad_token_id, | ||
| use_cache=True, | ||
| ), |
paddlenlp/generation/utils.py
Outdated
Comment on lines
906
to
910
| logger.warning("`max_length` will be deprecated in future, use" " `max_new_token` instead.") | ||
| generation_config.max_new_token = generation_config.max_length | ||
|
|
||
| if generation_config.min_length != 0 and generation_config.min_new_token == 0: | ||
| logger.warning("`min_length` will be deprecated in future, use" " `min_new_token` instead.") |
There was a problem hiding this comment.
Suggested change
| logger.warning("`max_length` will be deprecated in future, use" " `max_new_token` instead.") | |
| generation_config.max_new_token = generation_config.max_length | |
| if generation_config.min_length != 0 and generation_config.min_new_token == 0: | |
| logger.warning("`min_length` will be deprecated in future, use" " `min_new_token` instead.") | |
| logger.warning("`max_length` will be deprecated in future releases, use `max_new_token` instead.") | |
| generation_config.max_new_token = generation_config.max_length | |
| if generation_config.min_length != 0 and generation_config.min_new_token == 0: | |
| logger.warning("`min_length` will be deprecated in future releases, use `min_new_token` instead.") |
| @@ -46,6 +46,7 @@ | |||
| from paddle.utils.download import is_url as is_remote_url | |||
| from tqdm.auto import tqdm | |||
|
|
|||
| from paddlenlp.generation import GenerationConfig, GenerationMixin | |||
sijunhe
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
PR changes
Description
目录结构变动，PretrainedModel 适配 gconfig