dp main_grad #7293
Merged
dp main_grad #7293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7293 +/- ##
===========================================
- Coverage 59.34% 58.00% -1.35%
===========================================
Files 567 579 +12
Lines 83355 86266 +2911
===========================================
+ Hits 49466 50037 +571
- Misses 33889 36229 +2340 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
Nov 21, 2023
| # Multi-gpu training | ||
| if self.args.world_size > 1 and not self.args.use_hybrid_parallel: | ||
| model = paddle.DataParallel(model) | ||
| # Distributed training (should be after fp16 initialization) | ||
|
|
||
| if self.args.amp_master_grad: | ||
| mix_precision_utils.MixPrecisionLayer(model, dtype=self.amp_dtype) |
There was a problem hiding this comment.
这里的model的话，dp已经包了一层。确认一下 MixPrecisionLayer 再包一次影响不？
paddlenlp/trainer/training_args.py
Outdated
| @@ -810,9 +810,10 @@ def __post_init__(self): | |||
| self.pipeline_parallel_degree <= 1 | |||
| and self.tensor_parallel_degree <= 1 | |||
| and (not self.sharding or ShardingOption.FULL_SHARD in self.sharding) | |||
| and self.use_hybrid_parallel | |||
| ): | |||
| raise ValueError( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
dp main_grad