Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lora save #7504

Merged
merged 6 commits into from
Nov 24, 2023
Merged

Fix lora save #7504

merged 6 commits into from
Nov 24, 2023

Conversation

zzjjay
Copy link
Contributor

@zzjjay zzjjay commented Nov 22, 2023

PR types

Bug fixes

PR changes

Description

fix lora save in TP and PP mode

Copy link

paddle-bot bot commented Nov 22, 2023

Thanks for your contribution!

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (d4faef6) 58.00% compared to head (30e1081) 57.99%.
Report is 5 commits behind head on develop.

Files Patch % Lines
paddlenlp/peft/lora/lora_model.py 23.52% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7504      +/-   ##
===========================================
- Coverage    58.00%   57.99%   -0.02%     
===========================================
  Files          579      579              
  Lines        86264    86286      +22     
===========================================
+ Hits         50037    50039       +2     
- Misses       36227    36247      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sijunhe sijunhe merged commit 7b36d57 into PaddlePaddle:develop Nov 24, 2023
8 of 9 checks passed
@JunnYu
Copy link
Member

JunnYu commented Dec 22, 2023

@zzjjay @lugimzzz 这儿PR存在问题,单卡多卡llm推理报错,希望以后写的时候加上对应单测。
image

@zzjjay zzjjay deleted the fix_lora_save branch December 25, 2023 02:56
@zzjjay
Copy link
Contributor Author

zzjjay commented Dec 25, 2023

@zzjjay @lugimzzz 这儿PR存在问题,单卡多卡llm推理报错,希望以后写的时候加上对应单测。 image

感谢指正,已提pr修复~
#7714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants