[bloom] Add kv cache support for flash attention & fix bugs #7735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7735 +/- ##
========================================
Coverage 57.29% 57.30%
========================================
Files 584 584
Lines 87646 87628 -18
========================================
- Hits 50219 50215 -4
+ Misses 37427 37413 -14 ☔ View full report in Codecov by Sentry. |
w5688414
changed the title
wj-Mcat
reviewed
Dec 29, 2023
| @@ -17,10 +17,10 @@ | |||
|
|
|||
| def bloom_postprocess_past_key_value(past_key_values): | |||
| # (layer_num, bs, head_num/tensor_parallel_degree, prefixlen, head_dim)*2 | |||
| past_key_values = paddle.transpose(past_key_values, perm=[2, 0, 3, 1, 4]).split(2) | |||
| keys, values = paddle.transpose(past_key_values, perm=[2, 0, 1, 3, 4]).split(2) | |||
There was a problem hiding this comment.
这块 @lugimzzz 看看呗，之前用 bloom 训过 ptuning，精度是对齐的，如果这块调整之后是否会影响目前对齐的版本，前端的推理是否也需要调整呢？
| @@ -3,6 +3,7 @@ inference-predict: | |||
| mode: dynamic | |||
| max_length: 40 | |||
| batch_size: 2 | |||
| use_flash_attention: false | |||
There was a problem hiding this comment.
我单独写了一个单测，在单测里面加了use_flash_attention：true的配置
JunnYu
pushed a commit
that referenced
this pull request
Dec 29, 2023
* Add kv cache support for flash attention * Update chatglm flash attention version check * Add test for flash attention * Fix unitest bug * Add flash attention to predictor * Add flash attention2 * Add flash attention unitests * fix prefix decoder * remove unused comments * Update unitest * Update unitest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
PR changes
Description
TODO: